@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@danieldoglas In main branch, the text is "Test Preferences". In new design, we use "Testing Preferences". What should we use?

@tienifr please use the text from the new design

I just asked for the translations in slack. Once all the translations are added, you can review PR @alitoshmatov

@danieldoglas Can you help check this slack thread?

@alitoshmatov I think you can review this PR while the internal team fulfills the translations

The hovered row here should be going full width of the card:

@alitoshmatov All translations are added

@shawnborton I fixed comment

@tienifr subtitle styles are not matching. Also, I think the alignment is a bit off, I think it should match subtitles in other pages, for example about page.

Also alignment of clear cache and restart menu item is off. Here also I think it should match styles in about page which also has similar menu items

PR:

Design:

Hmm I think the Design might actually be off in this case, just slightly.

As long as this matches other rows in cards in Account Settings like these:

Then we're good to go.

subtitle styles are not matching

Good catch on this, let's fix. Again, take a look at the other places in Settings like Security and About for inspiration on correct implementation.

• I fix two issues you mentioned:

subtitle styles are not matching

alignment of clear cache and restart menu item is off

• Below is the result:

Design	PR

This is looking pretty good. I think the illustration in the header needs to be a bit bigger and centered:

And I ran into some weirdness with the nav on smaller viewports. Maybe that's unrelated to this, I'm not sure, so I thought I'd call it out:

• Random nav item is "active" even though nothing should be active
• Screens sometime animate in/out from the wrong side

Not the lightbulb, but the animated lottie illustration in the card header area.

Oh sorry. I misunderstood @dannymcclain 's thought

Do we have any ability to increase the size of the inner lottie illustration or do we need to supply a new lottie file for that?

We can increase the size of the inner lottie by update these props, but I think it will be better if we supply a new lottie file

Cool, I think we might be fine if we just do my suggestion above here - can you please try that and report back? Thanks!

@shawnborton I fixed the issue "the illustration in the header needs to be centered". Below is result:

@shawnborton I just merged main, and there is a new option, named "Save the world". So what is the correct order when displaying these options? Currently this PR, is:

Currently this PR, is:

That order looks good to me.

I fixed the issue "the illustration in the header needs to be centered". Below is result:

This also looks good to me! I'd say we're ready for final review then. Thanks for the adjustments!

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/39230/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/39230/NewExpensify.dmg	https://39230.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Looks like the header height is incorrect:

It should be 220px

@shawnborton I fixed this. Result:

Thanks!

@alitoshmatov can you please give this a review? Thanks!

@alitoshmatov Please help review PR once you have a chance

Reviewing

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.4.63-0 🚀

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀